Skip to content

Fix header location for zephyr 3.2 for udp.#117

Open
gseqBE wants to merge 2 commits intomicro-ROS:humblefrom
boston-engineering:fix/zephyr-3.2-header-fix
Open

Fix header location for zephyr 3.2 for udp.#117
gseqBE wants to merge 2 commits intomicro-ROS:humblefrom
boston-engineering:fix/zephyr-3.2-header-fix

Conversation

@gseqBE
Copy link
Contributor

@gseqBE gseqBE commented Dec 23, 2022 •
edited
Loading

Not sure if the module is ready for Zephyr 3.2 yet, but here is a fix for compilation for udp. Serial transport not affected.

  1. Header Path change(commit-1)
    image

Changelog of zephyr 3.2 specifies this:
image

https://docs.zephyrproject.org/3.2.0/releases/release-notes-3.2.html

  1. Example header update(commit-2)

image

Documentation:
image
https://docs.zephyrproject.org/3.2.0/releases/release-notes-3.2.html

Edit 1:
Added to prj.conf for testing udp(compile only):

CONFIG_MICROROS_TRANSPORT_UDP=y
CONFIG_MICROROS_AGENT_IP="192.168.1.234"
CONFIG_MICROROS_AGENT_PORT="8888"

# Microros Configuration
CONFIG_MICROROS_NODES="1"
CONFIG_MICROROS_PUBLISHERS="25"
CONFIG_MICROROS_SUBSCRIBERS="15"
CONFIG_MICROROS_CLIENTS="2"
CONFIG_MICROROS_SERVERS="2"
CONFIG_MICROROS_RMW_HISTORIC="4"
CONFIG_MICROROS_XRCE_DDS_MTU="512"
CONFIG_MICROROS_XRCE_DDS_HISTORIC="4"
CONFIG_NETWORKING=y
CONFIG_NET_UDP=y
CONFIG_NET_TCP=y
CONFIG_NET_IPV6=y
CONFIG_NET_IPV4=y
CONFIG_NET_SOCKETS=y
CONFIG_NET_SOCKETS_POSIX_NAMES=y
CONFIG_POSIX_MAX_FDS=6
CONFIG_NET_CONNECTION_MANAGER=y
CONFIG_NET_CONFIG_INIT_TIMEOUT=5

@pablogs9
Copy link
Member

pablogs9 commented Dec 30, 2022

@mergify backport main foxy galactic

@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2022 •
edited
Loading

backport main foxy galactic

🟠 Waiting for conditions to match

Details
  • merged [📌 backport requirement]

@pablogs9
Copy link
Member

pablogs9 commented Dec 30, 2022

This will be merged when Zephyr 3.2 is supported

@cmorganBE
Copy link

cmorganBE commented May 12, 2023

@pablogs9 are there plans to support zephyr 3.2 in the near future? Was hoping we could get this PR merged in.

@pablogs9
Copy link
Member

pablogs9 commented May 12, 2023

@Acuadros95 do we support 3.1 right? Is possible to update to 3.2 as @cmorganBE mentions?

@cmorganBE
Copy link

cmorganBE commented May 12, 2023

I was actually trying to test against 3.3 (the latest stable release) and was running into boatloads of warnings as the old headers are nearing removal. Was planning at least to fire up a ethernet based test to test round trip time etc. I had to make some other changes to get things to compile but I'm not sure if this PR will fix those yet, plan to re-test as soon as its merged.

@pablogs9
Copy link
Member

pablogs9 commented May 16, 2023

PTAL @Acuadros95

@Acuadros95 Acuadros95 self-assigned this May 17, 2023
clementlgl
clementlgl reviewed Jul 24, 2024
View reviewed changes
modules/libmicroros/microros_transports/udp/microros_transports.h
@@ -18,8 +18,13 @@
#include <unistd.h>

Copy link

@clementlgl clementlgl Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include <version.h>

We need to include the version.h file to use ZEPHYR_VERSION after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@clementlgl clementlgl clementlgl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Acuadros95 Acuadros95

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gseqBE @pablogs9 @cmorganBE @clementlgl @Acuadros95